Skip to content

Conversation

@nandenjin
Copy link
Owner

  • Keep contrast between link color and background color
  • Add underline to links

Copilot AI review requested due to automatic review settings December 4, 2025 15:21
@nandenjin nandenjin self-assigned this Dec 4, 2025
@nandenjin nandenjin enabled auto-merge December 4, 2025 15:21
@nandenjin nandenjin merged commit 715ef2c into dev Dec 4, 2025
8 of 9 checks passed
@nandenjin nandenjin deleted the fix-keep-contrast branch December 4, 2025 15:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the visual accessibility of hyperlinks by using a higher contrast color and making underlines always visible. The link color is changed from #0074e4 to #05a (a darker blue with better contrast), and links now always display an underline instead of only on hover.

  • Changed link color to #05a for improved contrast with the background
  • Added persistent underlines to all links with appropriate offset spacing
  • Preserved clean styling for table of contents links by overriding the underline

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}
color: #05a;
text-decoration: underline;
text-underline-offset: 0.2em;
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the :hover state means links no longer provide visual feedback when users hover over them. For better accessibility and user experience, consider adding a hover state that changes the color or styling. For example:

a {
  color: #05a;
  text-decoration: underline;
  text-underline-offset: 0.2em;

  &:hover {
    color: #039;
  }
}

This maintains the accessibility improvements while providing visual feedback for mouse users.

Suggested change
text-underline-offset: 0.2em;
text-underline-offset: 0.2em;
&:hover {
color: #039;
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants